Update npm-scripts to support Windows #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have deployed this package over to lambda and I get the following error!
I had chrome working when deploying from a unix based system. Based on unix, the Lambda's size is 42mb, Windows is 12mb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request removes all Unix-specific commands from the NPM-scripts and replace them with cross-platform commands, thereby allowing this project to built on Windows.
I have tested these changes on Windows and they produce a package.zip.
Since I currently do not have access to a Unix-system I can neither verify if the changes also altered the behaviour nor if this is still working on Unix, so this should be tested before merging.
Fixes #6 and fixes #14.